Skip to content

feat: the tree in Problems panel supports onSelect event#712

Merged
wewoor merged 1 commit into
mainfrom
feat/problemsOnSelect
Mar 14, 2022
Merged

feat: the tree in Problems panel supports onSelect event#712
wewoor merged 1 commit into
mainfrom
feat/problemsOnSelect

Conversation

@kiwiwong

Copy link
Copy Markdown
Collaborator

Description

The tree in Problems panel supports onSelect event.

Fixes #413

Changes

  • Added onSelect function to ProblemsController and ProblemsService

@kiwiwong
kiwiwong requested review from mortalYoung and wewoor March 11, 2022 09:49
@kiwiwong kiwiwong self-assigned this Mar 11, 2022
@codecov

codecov Bot commented Mar 11, 2022

Copy link
Copy Markdown

Codecov Report

Merging #712 (dcdd706) into main (a5134b0) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #712   +/-   ##
=======================================
  Coverage   91.33%   91.34%           
=======================================
  Files         189      189           
  Lines        5942     5947    +5     
  Branches     1426     1426           
=======================================
+ Hits         5427     5432    +5     
  Misses        508      508           
  Partials        7        7           
Impacted Files Coverage Δ
src/model/problems.tsx 100.00% <ø> (ø)
src/controller/problems.tsx 100.00% <100.00%> (ø)
src/services/problemsService.ts 100.00% <100.00%> (ø)
src/workbench/problems/paneView/index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5134b0...dcdd706. Read the comment docs.

@mortalYoung mortalYoung left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wewoor wewoor left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wewoor
wewoor merged commit 4c809eb into main Mar 14, 2022
@wewoor
wewoor deleted the feat/problemsOnSelect branch March 14, 2022 07:22
@wewoor wewoor added this to the 0.9.0-beta.5 milestone Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The Problems panel tree need to support onSelect event

3 participants